I noticed that many of the tests of DagBags operate on a specific DAG
only, and don't need to load the example or test dags. By not loading
the dags we don't need to this shaves about 10-20s of test time.
Nothing huge, but every little bit counts.
**Before**:
+ nosetests tests.models.DagBagTest
............
----------------------------------------------------------------------
Ran 12 tests in 30.855s
OK
[2018-09-28 22:42:17,846] {settings.py:193} DEBUG - Disposing DB connection
pool (PID 1467)
real 0m47.582s
user 0m8.300s
sys 0m4.700s
**After**:
+ nosetests tests.models.DagBagTest
............
----------------------------------------------------------------------
Ran 12 tests in 7.784s
OK
[2018-09-28 22:44:39,475] {settings.py:193} DEBUG - Disposing DB connection
pool (PID 1490)
real 0m30.399s
user 0m9.960s
sys 0m3.180s
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this
extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have
squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how
to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
[ Full content available at:
https://github.com/apache/incubator-airflow/pull/3974 ]
This message was relayed via gitbox.apache.org for [email protected]
