It might be better to have a `createConsumer(Map<String, Object> props)` method 
and `createConsumer()` method that does everything here except the subscribe, 
and to leave the subscribe call (which is one method invocation) to the caller. 
(Probably should mention the latter in the JavaDoc for this method.)

This additional control will make it easier for users to create a consumer that 
fits their needs. And since this method is currently only called from within 
the `consume(...)` method, there's little downside in having the caller do the 
subscribe.

[ Full content available at: https://github.com/apache/kafka/pull/5516 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to