Nit: Because NPE is throw in `Objects.requireNonNull`, I am wondering, if it 
would be cleaner like this:
```
if (duration == null) {
  throw new IllegalArgumentException("[" + name + "] shouldn't be null.");
}
try {
  return duration.toMillis();
catch (final ArithmeticException e) {
  throw new IllegalArgumentException("[" + name + "] can't be converted to 
milliseconds. ", e);
}
```

(Similar below)

[ Full content available at: https://github.com/apache/kafka/pull/5682 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to