@kakoni from what I understood, nobody uses this image for production, most people are using https://hub.docker.com/r/amancevice/superset/, so for now, I wouldn't bother tackling this question.
In #5966, the objective is clearly to simplify the experience of the developer, both for the backend and the frontend. Some things that differs in your PR: - your build the frontend in the entrypoint.sh. My take was to build it once in the image, and if the desire was to do development, the dev would run dev-server on its host, not in docker (that's not needed to do it in docker since running dev-server is happening all in memory). That being said, it means that if the frontend code change but the dev does not want to run dev-server, then he has to rebuild the image… that's maybe not the best, we could include building the front as part of starting the image. - yours build the image directly from docker-compose while mine lets the dev build it himself. I think you solution is more elegant. WDYT? Would you agree that I incorporate those changes in my PR and that we continue with it? Since it covers more things too. [ Full content available at: https://github.com/apache/incubator-superset/pull/5802 ] This message was relayed via gitbox.apache.org for [email protected]
