Well, review first ;)
(Just noticed the merge _is_ a bit messed up as it pulled in all the changes
into your branch individually, but your actual change is simple enough:
```diff
- this.applicationId = (String)
BuildHelper.getBuildConfigValue(cordova.getActivity(), "APPLICATION_ID");
- this.applicationId = preferences.getString("applicationId",
this.applicationId);
+ this.applicationId = cordova.getContext().getPackageName();
```
I looked into the history of that code you removed:
Initially added here:
https://github.com/squallstar/cordova-plugin-camera/commit/00e0a7dc469133faf92b46f0d72112d4d873844e#diff-f2e83abdaf34884df7e74b6493cf2dd7L134
The value used later in these 2 locations:
https://github.com/squallstar/cordova-plugin-camera/commit/00e0a7dc469133faf92b46f0d72112d4d873844e#diff-f2e83abdaf34884df7e74b6493cf2dd7R294
https://github.com/squallstar/cordova-plugin-camera/commit/00e0a7dc469133faf92b46f0d72112d4d873844e#diff-f2e83abdaf34884df7e74b6493cf2dd7L794
Then modified here:
https://github.com/squallstar/cordova-plugin-camera/commit/61064ae3ed6c520e6de6646566b83772854d0fea
Correct that this value (plus `.provider` added at the end) is mainly used for
getting a file name?
I don't know anything about Android, is what and where you are getting the
value from identical?
[ Full content available at:
https://github.com/apache/cordova-plugin-camera/pull/320 ]
This message was relayed via gitbox.apache.org for [email protected]
