Looks good in general - Three things I noticed: ### Bad/non-existing headers - no indication of the license web-facesconfig_1_0.dtd: web-facesconfig_1_1.dtd: Please download fresh copies from here: http://www.oracle.com/webfolder/technetwork/jsc/dtd/index.html There are the correct headers added GPL+CDDL Version (mentioning that you did that in the commit message would be great, so that it is documented and noone can suspect tinkering)
### Missing info in the xml.xsd I think it would be good to add the information of the source of the xml.xsd file. Please see `enterprise/web.core/src/org/netbeans/modules/web/taglib/resources/xml.xsd xml.xsd` for a sample ### AnnotationsTest.java Before the PR I had a test pass rate of 57passed, 1 failed, 2 errors. With your change I gets down to 55/3/2. When I revert your change, I'm back to 57/1/2. Could you please recheck that change? [ Full content available at: https://github.com/apache/incubator-netbeans/pull/935 ] This message was relayed via gitbox.apache.org for [email protected]
