It wouldn't be wrong, but I think `<=` is also right, and it's a tighter bound.

Let's say we have buffered an event with time 10 at stream time 10 and the 
suppressDuration is 1. The expiry time is `10-1 = 9`. minTimestamp is 10, and 
`10 <= 9` is false, so we don't evict.

Then, we get an event with time 11 at stream time 11. Now, the expiry time is 
`11-1=10`. minTimestamp is still 10, but now the check is `10 <= 10`, so we 
evict that first event.

I think this matches up to the intention of saying "suppress for 1 ms".

[ Full content available at: https://github.com/apache/kafka/pull/5693 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to