#### What does this PR do?

Add TO Go configurable Riak port.

If port is not configured, a default is used, which is the same as the existing 
hard-coded port.

The "API Tests" don't support Riak yet, but unit tests pass, and I tested this 
manually, verified a configured port was used, and that TO behaved exactly as 
before if a port was not configured.

#### Which TC components are affected by this PR?

- [ ] Documentation
- [ ] Grove
- [ ] Traffic Analytics
- [ ] Traffic Monitor
- [x] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] Other _________

#### What is the best way to verify this PR?

With a complete TO setup, including Riak/Traffic Vault, set the key `riak_port` 
in `cdn.conf`, and request a Riak endpoint such as `/api/1.2/riak/ping`, and 
verify the configured port is used (you don't have to actually configure Riak 
to use that port, you should be able to check the error logs of TO and see 
failed attempts to get to the port you set).

Remove the `riak_port` key, and verify TO uses the default port of `8087`. With 
a default Riak installed and configured, this should be the default, and a 
request to `/api/1.2/riak/ping` should succeed.

#### Check all that apply

- [ ] This PR includes tests
- [ ] This PR includes documentation updates
- [ ] This PR includes an update to CHANGELOG.md
- [ ] This PR includes all required license headers
- [ ] This PR includes a database migration (ensure that migration sequence is 
correct)
- [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)

<!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at

      http://www.apache.org/licenses/LICENSE-2.0

    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
-->





[ Full content available at: https://github.com/apache/trafficcontrol/pull/2896 
]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to