The test failures look legit (although are not a big deal) and are related to the renaming of HLLCV1. I don't think it's important that the value stay the same, so I think updating the tests is fine.
``` Failed tests: org.apache.druid.sql.calcite.http.SqlResourceTest.testCsvResultFormat(org.apache.druid.sql.calcite.http.SqlResourceTest) Run 1: SqlResourceTest.testCsvResultFormat:500 expected:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.HLLCV1,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.HLLCV1,, , ]> but was:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, , ]> Run 2: SqlResourceTest.testCsvResultFormat:500 expected:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.HLLCV1,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.HLLCV1,, , ]> but was:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, , ]> Run 3: SqlResourceTest.testCsvResultFormat:500 expected:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.HLLCV1,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.HLLCV1,, , ]> but was:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, , ]> Run 4: SqlResourceTest.testCsvResultFormat:500 expected:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.HLLCV1,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.HLLCV1,, , ]> but was:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, , ]> ``` [ Full content available at: https://github.com/apache/incubator-druid/pull/5957 ] This message was relayed via gitbox.apache.org for [email protected]
