> Remove the added test, because the signing of arbitrary headers is already 
> covered by existing tests.

right.  

> Add a test to confirm that the new header is added when the plugin is 
> configured to add it.

The Catch unit tests test only the v4 calculation. Your changes are in the 
plugin which will be hard to test from the unit-test we have. I guess you would 
need to create AuTest test which you will have to be created from scratch for 
this plugin (it will be great but it is up to you).

[ Full content available at: https://github.com/apache/trafficserver/pull/4302 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to