When curl_exec fails, more detailed failure information is available by calling curl_error. Include this error information in the message in the thrown TTransportException.
Also change the comparison of the return value of curl_exec to explicitly check for boolean false, so as to distinguish from an empty response body (per the PHP documentation on this subject). Changes have been tested and running in production at Thumbtack for the past several days, and it's working as expected. TCurlClient doesn't seem to have any existing test suite to update. [ Full content available at: https://github.com/apache/thrift/pull/1602 ] This message was relayed via gitbox.apache.org for [email protected]
