The original tests for FileSystem already test the behavior of LocalFileSystem with atomic move. The other FileSystem implementations like HDFS do not have that behavior though.
I considered that to test FileSystems.rename we could either: 1) Use a LocalFileSystem configured in a way to behave like other FS implementations (of course you would not use it in that manner normally) 2) Have a standard test suite for FileSystems but run it in the tests of each FileSystem implementation I opted for approach 1) here but I get the impression that is not particularly clear so perhaps 2) would be better after all? [ Full content available at: https://github.com/apache/beam/pull/6289 ] This message was relayed via gitbox.apache.org for [email protected]
