Thanks for your change, @manuzhang, I was also not aware of this syntax. It is documented in https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-platform-specific-dependencies and in more detail in https://www.python.org/dev/peps/pep-0508/. We should use it to simplify our setup.py and instead of `REQUIRED_PACKAGES_PY3_ONLY`/`REQUIRED_PACKAGES_PY2_ONLY`. @manuzhang - would you be interested in adding this cleanup to this PR?
As for this change: - I do notice that more typehints tests fail for Python 3.7, but I did not see any effect whether we install `typing` or not. I did see errors coming from `futures` package, and removing it helped to significantly reduce the number of failures on 3.7. As per https://pypi.org/project/typing/: in Python 3.5 and later, the typing module lives in the stdlib, and installing this package has no effect. I think we should file a Jira and do a little more investigation to rootcause the issue you are facing. I wonder if it may be platform-specific. [ Full content available at: https://github.com/apache/beam/pull/6543 ] This message was relayed via gitbox.apache.org for [email protected]
