@rayokota exactly I wanted to highlight that the fact that the underlying type 
is primitive is not transitive to the logical type. Of course this cast would 
fail for other primitives such as string as defined in the type. In that sense 
the assertions are a bit misleading at the start of this method. 

I missed that `isPromotable` takes `Type` arguments and not `Schema` given that 
it's a method of the projector class. 

The fix looks good to me. LGTM

[ Full content available at: https://github.com/apache/kafka/pull/5736 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to