@himanshug @dclim thanks for the review. I believe that you guys want to add documentation about Druid's partition support rather than this specific configuration. That sounds helpful and I definitely agree with that. But, hash partitioning itself is not added in this PR. This PR just adds support for specifying partition keys. If you don't mind, I'd like to do in a follow-up PR. Does it make sense?
> Wouldn't it get ignored if forceGuaranteedRollup is false? @dclim this is true, thanks. I fixed the doc. But, `forceGuaranteedRollup` is useful only with `numShards > 1`. If `forceGuaranteedRollup` is set, all other configurations like `maxTotalRows` or `targetPartitionSize` get ignored. This is only because we don't support range partitioning yet which can be used with `targetPartitionSize` together. [ Full content available at: https://github.com/apache/incubator-druid/pull/6326 ] This message was relayed via gitbox.apache.org for [email protected]
