In this case, it's purely a mathematical statement. I set the "close time" equal to the first ms in which a record is late, so by definition if window_end==close_time, it is late. Note how the comparison above uses `>`.
I could move the "close time" forward 1ms (adding 1 to the calculation of it above), used `>=` in the comparison, and then what you say would be true, and we'd have no need to add 1 here. I think either way, we're adding a 1 to some calculation in this method, and we'd need a similar explanatory comment to clarify why. I'm open to swapping the semantics if you think it's more intuitive the other way. [ Full content available at: https://github.com/apache/kafka/pull/5742 ] This message was relayed via gitbox.apache.org for devnull@infra.apache.org
