The issue of not calling replicaFetcherManager.removeFetcherForPartitions() in line 1278 is that in the case of controlled shutdown, we avoid adding the partitions to the fetcher. This means that existing partitions won't be removed from the fetcher. This may cause replicas removed from ISR during controlled shutdown to be added back to ISR again.
Also, if we do this, the state-change logging after replicaFetcherManager.removeFetcherForPartitions() probably needs to be moved too. [ Full content available at: https://github.com/apache/kafka/pull/5661 ] This message was relayed via gitbox.apache.org for devnull@infra.apache.org
