All "Why are we removing these assertions?" is as you say, we do not send those 
state updates via `TaskManagerActions.updateTaskExecutionState`. Maybe we can 
verify 
`TaskManagerActions.notifyFatalError`/`TaskManagerActions.failTask`/`TaskManagerActions.notifyFinalState`
 but all of them don't include detail task state. **And I think verify the 
final state is enough for the test**

Besides, as the communication with @Clarkkkkk , `TaskTest` is a test based on 
legacy mode, there is a pull request #6778 to port it to FLIP-6 code base.

I think the main issue is whether we replace `notifyObservers` with 
`TaskManagerActions.updateTaskExecutionState`. My opinion is not for now to 
hold the current(FLIP-6) message flow and defer the decision. If so, we remove 
those assertion because we don't send those message and the assertion should 
not hold.

[ Full content available at: https://github.com/apache/flink/pull/6729 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

Reply via email to