ralf0131 commented on issue #2586: Optimize RoundRobinLoadBalance URL: https://github.com/apache/incubator-dubbo/pull/2586#issuecomment-427389452 This pull request looks good to me. Nice work! The time complexity is O(n), where n is the number of invokers, which is a significant improvement to the previous one, which is O(n*w), where n is the number of invokers, and w is the max weight of the invokers. I'd prefer to have more unit tests for this algorithm.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
