Hi! This change placed these three `if (FillSymbolInferShape...` calls inside a 
new block, the `if (ret == 0) {` now on line 1584. Are you saying indentation 
shouldn't be changed even if a new scope is introduced around the code?

As for inserting the line break on the first of those calls, without that, your 
own style checker failed because that line was > 100 characters. I followed the 
convention with the rest of this file to make that line shorter.

Am I missing something, or do any of these changes actually violate your style 
guide?

[ Full content available at: 
https://github.com/apache/incubator-mxnet/pull/12733 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

Reply via email to