I don't see any explicit check in `updateSharedConfig()` to see if the 
application is already running. I ran the following test in `FluoAdminImplIT` 
to see
```
@Test
  public void test() throws Exception {

    FluoConfiguration localConfig = new FluoConfiguration(config);
    localConfig.setProperty("fluo.test123", 
"${fluo.connection.application.name}");
    Assert.assertEquals(localConfig.getApplicationName(), 
localConfig.getString("fluo.test123"));

    try (FluoAdmin admin = new FluoAdminImpl(localConfig)) {

      InitializationOptions opts =
          new 
InitializationOptions().setClearZookeeper(true).setClearTable(true);
      // admin.initialize(opts);
      Thread.sleep(20000);

      admin.updateSharedConfig();
    }
  }
```
With `admin.initialize(opts);` commented out it passes, but with that line not 
commented out it fails due to an `AlreadyInitializedException` (from within 
`admin.initialize()`).

I can add an `applicationRunning()` check to the beginning of 
`updateSharedConfiguration()`. Do we want to limit calling that method on only 
stopped applications?

[ Full content available at: https://github.com/apache/fluo/pull/1052 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

Reply via email to