It looks like not just the prose, but also the code of this patch did not take 
into account all the feedback on the C++ code: 
https://github.com/apache/parquet-cpp/pull/432

I'm going to pause my review for a moment so as not to overwhelm with repeated 
feedback and give you time to incorporate that feedback. This line made me 
notice the difference because there was a long discussion on the other patch 
about how to incorporate `Algorithm algorithm` into the constructor.

[ Full content available at: https://github.com/apache/parquet-mr/pull/521 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to