Regarding my comment about mocking `DruidLeaderClient` in benchmark, I think the real issue is that `PlannerFactory` needs `TimelineServerView`, `ObjectMapper`, and `DruidLeaderClient`s. Since this class is just a factory which is responsible for creating a new planner, it's not supposed to get information from TimelineServerview or leaderClients on its own. This makes me confused until tracking the whole change related to those parameters.
I think the same design for `DruidSchema` can be applied to here too. `DruidSchema` also needs `TimelineServerView`, but it's being injected and so `TimelineServerView` is not exposed here. Similarly, you can inject `SystemSchema` instead of these parameters. Actually, you've already made it injectable. Why don't you use it? [ Full content available at: https://github.com/apache/incubator-druid/pull/6094 ] This message was relayed via gitbox.apache.org for devnull@infra.apache.org
