> Do you mean to remove the setters and always create a new 
> SegmentMetadataHolder object when any of the member needs update. And replace 
> the entry in segmentMetadataInfo map in DruidSchema every time update is 
> required.

Yeah, this is what I meant. I think reducing the scope of concurrent access is 
more important here than what kind of lock types we use. As I commented 
[here](https://github.com/apache/incubator-druid/pull/6094#discussion_r221365849),
 the concurrency control algorithm is spanned over multiple places, which makes 
us difficult to understand and makes potential bugs even in the future.

[ Full content available at: 
https://github.com/apache/incubator-druid/pull/6094 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to