@reminisce  Code style is not consistent in this file. SubgraphSelector use 
different coding style with SubgraphProperty, which making me confusing which 
coding style should to follow. For example, SubgraphSelector uses /*! */ style 
comment with param description, and long parameter name(eg nnvm::Node 
&input_node), while SubgraphProperty uses \\ style comment without param 
description, and short parameter name(eg. const nnvm::Symbol &s).
Changing these 2 SubgraphProperty functions into SubgraphSelector style doesn't 
make sense to me. If you insist, I'd like to adjust the code style for whole 
file.

[ Full content available at: 
https://github.com/apache/incubator-mxnet/pull/12530 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

Reply via email to