[GitHub] [ambari] zeroflag commented on pull request #2430: [AMBARI-24742] Implementing a new util class to be used in case we want to encrypt/decrypt sensitive information using custom/environment master key (also injected into Guice)

[GitHub]

How about naming it AESEncryptionService instead of EncryptionServiceImpl? I'm 
not a big fan of the *Impl convention which assumes only one implementation. I 
would rather name it after some unique property of the specific implementation. 
As I see this implementation always uses AES so why not put this into the name.

[ Full content available at: https://github.com/apache/ambari/pull/2430 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org