This fixes #2719 where private gateway IP might be incorrectly programmed on a guest network nic. The VR would now check ipassoc requests by mac addresses than provided nic/device id in case they are wrong.
The root cause is that the device id information is lost when aggregated commands are created upon starting of a new VPC VR, without the correct device id in ip_associations json it mis-programs the VR. ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs #2719 ## How Has This Been Tested? Deploy VPC Deploy a guest VM on a tier Add a private gateway Restart the VPC with cleanup=true The private gateway should be on correct dev idx (previously both guest network and private gw would be on eth2, eth3 will not have any ip) /cc @PaulAngus @borisstoyanov @blueorangutan package [ Full content available at: https://github.com/apache/cloudstack/pull/2888 ] This message was relayed via gitbox.apache.org for [email protected]
