Hi @mrsrinivas , thanks for your PR! I've briefly looked it over and have two quick comments - however both of these I think come down more to personal preference than anything else!
Regarding the unused throws clauses, I don't really think these hurt. In fact it could be argued that it is good practice to declare this on any test, since it saves you from having to change the test if the implementing code ever changes and throws an exception. But seeing as the rest of the test cases don't do this either I'd say removing them is fine. As for the lambda functions, it seems like a lot of code to encapsulate in a lambda function - I personally feel like lambdas should ideally have only one line. Plus you loose the return type, hence your IDE won't alert you if you mess up the return type. Both are no deal breakers, but I'm unsure what we gain by making this a lambda function tbh. Again, just my personal opinion and really comes down to taste I think. [ Full content available at: https://github.com/apache/kafka/pull/5681 ] This message was relayed via gitbox.apache.org for devnull@infra.apache.org
