Thanks for clarification, @robertwb. With this assumption, we can simplify the logic here. This assumption is also consistent with `Top` docstring, however I was confused by https://github.com/apache/beam/blob/1c573ffba014f6969a689d0e6cdcace31358885d/sdks/python/apache_beam/transforms/combiners.py#L319. robertwb@, would you be comfortable with merging PR as with a clean-up in a follow-up change? I can own the cleanup and can send you a PR with a few comment changes, and assertions here and there that ensure that that `key_fn` and `compare` are not used together.
[ Full content available at: https://github.com/apache/beam/pull/6570 ] This message was relayed via gitbox.apache.org for devnull@infra.apache.org
