## Description
<!--- Describe your changes in detail -->
Network.Service and Network.Provider were missing a toString() method.
Added toString() methods so appending instances, or a collection of instances 
to a String, will result in an understandable String.

### Before
com.cloud.network.Network$Provider@11763e57 requires services: 
[com.cloud.network.Network$Service@4f9871a2]
### After
Provider Network.Provider[name=NuageVsp] requires services: 
[Network.Service[name=Connectivity]]


<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality 
to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

## GitHub Issue/PRs
<!-- If this PR is to fix an issue or another PR on GH, uncomment the section 
and provide the id of issue/PR -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->

<!-- Fixes: # -->
Fixes: #2881

## How Has This Been Tested?
Manually, added Unit Test to validate exception message.

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that 
apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to 
help! -->
- [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
Testing
- [x] I have added tests to cover my changes.
- [ ] All relevant new and existing integration tests have passed.
- [ ] A full integration testsuite with all test that can run on my environment 
has passed.



[ Full content available at: https://github.com/apache/cloudstack/pull/2889 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

Reply via email to