I think it might be worth de-magicifying this shell command a little. Maybe some of the following? * declare a variable or method for the string and reference it instead of having three copies (the logic is not trivial, and a typo in one would be both bad and hard to detect) (also, it makes it clear that the command is the same for all three nodes) * add a brief comment explaining what it's doing (we don't need an explanation of exactly what is happening, since we can read the `awk` manual, but it would help to just have a high level description) (I guess if you declare a variable or method, the name of it could also serve this purpose) * use triple-quotes at the outermost level so you don't have to escape so much in the string
[ Full content available at: https://github.com/apache/kafka/pull/5754 ] This message was relayed via gitbox.apache.org for [email protected]
