@ewencp yes, agree that these tests should not be expensive. But when you say they must be comprehensive, does that mean creating multiple tests with different converters and transformation. I don't think that should be the purpose here. We need to ensure that the interfaces of these different components work well together. Plugging in different implementations of converters ensures their correctness, but that can be tested with unit tests. Here we want to make sure that all the components (through their interfaces, work correctly with each other). For example, a test could be extended to add a transformation and/or a dead letter queue to check if all of these pieces work well together (which is what `DeadLetterQueueIntegrationTest` does, btw). Variations of this test would be running the same test (move data through a connector pipeline) in the absence of the optional components and asserting the correct behavior.
in the light of the above comment, what about calling this test as `EndToEndSinkConnectorIntegrationTest`, and moving the test from `DeadLetterQueueIntegration` into this class as a `testWithDeadLetterQueue` test method? @rhauch @ewencp let me know what you think? [ Full content available at: https://github.com/apache/kafka/pull/5516 ] This message was relayed via gitbox.apache.org for devnull@infra.apache.org
