Nit: every conditional needs to have braces (per the code style) not nit: I find this logic a little difficult to follow. Contrary to what @mjsax suggested, wouldn't it be pretty straightforward to map the old semantics on to the new ones like this: * negative numbers => 0 * 0 => Long.MAX_VALUE * all other arguments stay the same ?
Then, the old close method could just transform its arguments and call the new method, with no need to have this "new semantics" flag and an early return in the middle of the loop. [ Full content available at: https://github.com/apache/kafka/pull/5747 ] This message was relayed via gitbox.apache.org for [email protected]
