@mrsrinivas, thanks for the PR! I agree with @soenkeliebau about the throws clauses: removing `throws Exception` where truly not needed seems acceptable, though they don't really bother me as they're pretty minor.
I do question whether it's necessary to change the code from using anonymous inner classes to lambdas in the tests, for a couple of reasons. First, it's a minor change that affects multiple lines, making it more difficult to see the real changes that were made in that block of code. Second and more importantly, these changes may make it harder for the committer to more cleanly backport future fixes to older branches. Remember, we only started using Java 8 in 2.0, so backporting to earlier branches doesn't allow lambdas. I'd love to hear what a committer thinks about moving to lambdas, and whether my concerns are warranted. [ Full content available at: https://github.com/apache/kafka/pull/5681 ] This message was relayed via gitbox.apache.org for [email protected]
