Hi Marius, Note: I've discussed all of the points below with Marius on Skype so I'm summarizing for everyone's benefit.
See below On Oct 16, 2007, at 1:16 PM, Marius Dumitru Florea wrote: > Hi all, > > The statistics page needs improvement. See > http://jira.xwiki.org/jira/browse/XE-37 for a brief introduction. I > propose we take the following steps: > > 1) Extend the xwiki core api with: [snip] Sounds good to me. Make sure you use JDK 1.4 and not 1.5 for now since XWiki core is supposed to run on 1.4. > 2) Add in the com.xpn.xwiki.api.XWiki the following method: > > public StatsService getStatsService(){} +1 > 3) Extend the com.xpn.xwiki.stats.api.XWikiStatsService with: [snip] +1 > 4) Adjust the com.xpn.xwiki.stats.impl.XWikiStatsServiceImpl +1 > 5) In com.xpn.xwiki.api.XWiki there are 2 methods related to > statistics: > > * getCurrentMonthXWikiStats > * getRefererText > > We could duplicate this methods in the StatsService and deprecate > them in > XWiki. +1 Since you've finished points 1 through 5 please send a patch now in JIRA. The idea is to include it in 1.2M2 and to leave the UI (i.e. points 7 and 8 below) for later (we could release it as a separate application to start with or decide to add it in 1.2RC1 if we want to bend the RC rule or do a 1.2M3 with limited changes). > 6) Currently the xwiki chart macro doesn't support hidden (aka not > visible > in page) data sources. This is how the char macro is used now: > > {chart:type=time|source=type:table;table_number:4;...} > > I propose to extend the macro to allow the following usage: > > {chart:type=time|source=type:table;...} > {table} > | Series1 | Series2 > 2001-2 | 181.8 | 129.6 > 2001-3 | 167.3 | 123.2 > 2001-4 | 153.8 | 117.2 > {table} > {chart} > > This extension consists in: > * add chart macro's content to the parameters map given to the data > source > * adjust the TableDataSource to use this content when no > table_number is > specified Since the chart macro supports taking source from other documents let's use that feature. It'll also allow to have detailed data for each type of stats. > 7) Create the xwiki-platform-applications/statistics application to > host > the statistics related pages. Different stats will be displayed using > special panels that can be inserted into a page (see > http://llunati.xwiki.com/xwiki/bin/view/Albatross/PanelInPage for a > sample). I propose to use the Panels space for this pages (e.g use the > path src/main/resources/Panels). Vincent could help me with this. I propose to use a Statistics space instead and to make that space viewable by Admins only by default (since stats are off by default and since it's possible admins want to restrict stats to themselves - they can also change the rights to make them visible for everyone). > 8) Create the Stats page (aka the UI). The Stats page is now in the > XWiki > space, meaning it is not accessible for the regular user (event when > the > statistics module is enabled). I don't really like this. I like more > how > jira.xwiki.org shows me its stats even when I'm not logged in. In the > future, I think it would be great if the users could see page/space/ > wiki > stats much the same they see now the xwiki code of the page (e.g. > Show > > Stats). For the moment I propose to make only a single stats page > (XWiki.Stats). See above. Thanks and sorry again for the lag in my answer. -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
