On Fri, 11 Jan 2008 16:07:06 +0100, Vincent Massol wrote > Hi Ruslan, > > On Jan 11, 2008, at 3:55 PM, rssh wrote: > > > > > Good day, xwiki community. > > > > I want to discuss path, with allows to set in configuration name of > > main wiki > > database schema and prefixes for databases schemes of virtual wiki-s. > > > > This allows to use few wiki-based applications on one computer. > > > > Proposed path itself is attached. > > The work of this path is > > 1. add configuration variables: > > xwiki.db -- database schema name of main wiki instance. > > xwiki.virtual.db.prefix -- prefix for database scheme-s of virtual > > wiki-s. > > > > So, questions: > > a) where I must write documentation for this parameters ? > > b) can I submit JIRA issue now or exists some other things which i > > forgott. > > Thanks for the patch. I've looked at it quickly and here are some > comments: > > * Could you please ensure you're following the xwiki coding > conventions as defined here: > http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle. You can > also read this page: > http://dev.xwiki.org/xwiki/bin/view/Community/Contributing > > * Make sure you don't include diffs for stuff not related to your > changes. For example in your patch you have modified a license > header, you've also modified lots of other places (I think you > changed the line returns). >
Ok > * We already have a method for returning configuration parameters. > It's called XWiki.Param() (Note: with a wrong uppercase letter for a staticParam() differs from Param(), becouse one is callable from static context. Why -- because in some cases we need information about database scheme before any wiki was created. > method! We need to fix this). > I can do this [change Param to getParameter()]. Have you tested it in virtual mode (multiwiki)? This is an area that > should generate some problems I believe. > Very smoothly. I will try more today/tomorrow > Now to answer your questions: > > a) You can document it in the code itself and on xwiki.org here: > http://platform.xwiki.org/xwiki/bin/view/AdminGuide/Configuration > > b) yes for jira definitely. > > Thanks! > -Vincent > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs -- Ruslan Shevchenko GradSoft. http://www.gradsoft.ua _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
