Vincent Massol wrote:
> On Jan 11, 2008, at 6:28 PM, sdumitriu (SVN) wrote:
> 
>> Author: sdumitriu
>> Date: 2008-01-11 18:28:47 +0100 (Fri, 11 Jan 2008)
>> New Revision: 6782
>>
>> Modified:
>>   xwiki-platform/core/trunk/xwiki-core/pom.xml
>>   xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ 
>> render/groovy/GroovyTemplateEngine.java
>>   xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ 
>> store/XWikiHibernateBaseStore.java
> 
> [snip]
> 
>> Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ 
>> xwiki/store/XWikiHibernateBaseStore.java
>> ===================================================================
>> --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ 
>> store/XWikiHibernateBaseStore.java   2008-01-11 14:01:44 UTC (rev 6781)
>> +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ 
>> store/XWikiHibernateBaseStore.java   2008-01-11 17:28:47 UTC (rev 6782)
>> @@ -80,7 +80,7 @@
>>             try {
>>                  
>> setHibUrl(XWiki.class.getClassLoader().getResource(path));
>>             } catch (Exception ex2) {
>> -                log.error("Failed setting the Hibernate  
>> configuration file with any method, storage cannot be configured",  
>> ex2);
>> +                log.error("Failed setting the Hibernate  
>> configuration file with any method, storage cannot be configured");
> 
> Why are we removing the stack trace? This is an error and the stack  
> trace will help debug the error.
> 
> The fact that the test is wrongly written is a different matter IMO.  
> The test must be forgetting to initialize something.
> 
> But we do need the max amount of info when debugging an ERROR level  
> error.


It wasn't an error until a few days ago, when I made it so. It wasn't 
even reported before, it was considered something that cannot happen and 
ignored.

Sergiu
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to