> >
> >  during initialization of wiki (where exists calls of hibernate store)
> > context.getWiki()  return null, so this is impossible.
> 
> It should not be. When exactly do you have context.getWiki() null ?
> Maybe there is a problem in a particular case. I tested xwiki
> initialization and, in getSchemaFromWikiName, context's wiki is never
> null even the first time it's called in virtual or non virtual mode.
> 

 Hmm, I was see ifs (on xwiki==null) and belive that this 'if' is really was
needed.
 Now I just reread initXWiki and seen context.setWiki(this) on second line:
look's like you are right.

 Thanks,  I will retest this and return shortly.

> >
> > > best name for that parameter as it's only used in virtual mode and
> > > it's the main wiki database name I would prefer something like
> > > "xwiki.virtual.db.main". If this parameter means also the database
> > > name in non virtual mode I doubt it works as context's database is
> > > not taken into account in non virtual mode.
> > >
> >
> > I would vote against usage of 'xwiki.virtual.db.main' in non-virtual mode,
> > because find this confusing.
> >
> > (But you free to change names during/after import of the path)
> 
> You did not read all all I said :  "If this parameter means also the
> database name in non virtual mode I doubt it works as context's
> database is not taken into account in non virtual mode." What I said
> is than if it works only in virtual mode I would prefer a more clear
> name than wiki.db and the way you did I don't see how it could work 
> in non virtual mode. 

 Main usage of this parameter (for me) - is non-virtual mode and Oracle.
(I want to use already existent database which named other than 'xwiki'.
And it's work for me.)

> In fact it could make error with oracle  
> databases I think because it will use the configured name for update 
> schema and hibernate.cfg one for store and load.
> 

 No, it's work for me.
 (may be because of calls to table.setSchema() in updateSchema(), which called
first) 



--
Ruslan Shevchenko
GradSoft. http://www.gradsoft.ua

_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to