On Sun, Feb 24, 2008 at 2:44 PM, Vincent Massol <[EMAIL PROTECTED]> wrote: > > On Feb 24, 2008, at 1:26 PM, Jean-Vincent Drean wrote: > > >> > >> This method looks like a duplicate of the code in the XWiki class. > >> Why > >> is that? > >> > > > > Yes this is a duplicate, the problem here is that WatchListJob gets a > > wrapped context and getVirtualWikisDatabaseNames isn't accessible from > > api.XWiki. > > Well in that case why not propose to put it in the API? In any case we > must not have duplications so we need a solution. > > > > IMHO the underlying problem is that jobs don't get an unwrapped > > context and it'll have to be fixed, > > I agree. Why not fix this then? :) >
Ok done in 7932. > > I've prefered to duplicate this > > method in the plugin instead of adding a new method to api.XWiki, > > please tell me if I was wrong. > > Duplication is evil :) > Duplication removed in r7933. JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
