On Apr 10, 2008, at 5:23 PM, Artem Melentyev wrote:
> Hi, Vincent.
>
> Sorry. I commited in some hurry.
don't worry it was just to let you know in case you didn't already
know! :)
> I tried to modify the log, but got following:
>
> $ svn propedit svn:log --revprop -r9068
> svn: DAV request failed; it's possible that the repository's
> pre-revprop-change hook either failed or is non-existent
> svn: At least one property change failed; repository is unchanged
>
> Is the log modify doesn't work in our svn server?
unfortunately it's not configured no... we would need to ask Raff to
configure it...
Thanks
-Vincent
> Vincent Massol wrote:
>> Hi Artem,
>>
>> In general whenever you make a commit you must reference a JIRA issue
>> in your commit.
>> The reason is to keep tracability. If you don't put a jira issue then
>> this commit will not
>> appear in the subversion tab in jira for example.
>>
>> The format we use is:
>>
>> "
>> <JIRAID>: <JIRA description>
>>
>> <optional comment here>
>> "
>>
>> Thanks
>> -Vincent
>>
>> On Apr 10, 2008, at 4:11 PM, amelentev (SVN) wrote:
>>
>>> Author: amelentev
>>> Date: 2008-04-10 16:11:38 +0200 (Thu, 10 Apr 2008)
>>> New Revision: 9068
>>>
>>> Modified:
>>> xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
>>> store/hibernate/HibernateAttachmentVersioningStore.java
>>> Log:
>>> [misc] a bug in my prev commit
>>>
>>>
>>> Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/
>>> xpn/
>>> xwiki/store/hibernate/HibernateAttachmentVersioningStore.java
>>> ===================================================================
>>> --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/
>>> xwiki/
>>> store/hibernate/HibernateAttachmentVersioningStore.java 2008-04-10
>>> 14:07:22 UTC (rev 9067)
>>> +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/
>>> xwiki/
>>> store/hibernate/HibernateAttachmentVersioningStore.java 2008-04-10
>>> 14:11:38 UTC (rev 9068)
>>> @@ -60,6 +60,7 @@
>>> {
>>> try {
>>> final XWikiAttachmentArchive archive = new
>>> XWikiAttachmentArchive();
>>> + archive.setAttachment(attachment);
>>> executeRead(context, bTransaction,
>>> new HibernateCallback<Object>() {
>>> public Object doInHibernate(Session session)
>>> @@ -73,7 +74,6 @@
>>> return null;
>>> }
>>> });
>>> - archive.setAttachment(attachment);
>>> attachment.setAttachment_archive(archive);
>>> return archive;
>>> } catch (Exception e) {
>
> --
> Artem Melentyev
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
