On Apr 23, 2008, at 12:29 AM, Jean-Vincent Drean wrote: > On Tue, Apr 22, 2008 at 7:16 PM, Vincent Massol <[EMAIL PROTECTED]> > wrote: >> >> On Apr 22, 2008, at 7:05 PM, Jean-Vincent Drean wrote: >> >>> On Fri, Apr 18, 2008 at 7:54 PM, Vincent Massol <[EMAIL PROTECTED]> >>> wrote: >>>> +1 for releasing on Monday or Tuesday morning. >>>> >>>> Thanks >>>> -Vincent >>> >>> Sorry I haven't been able to do the release today, I'll release1.4M2 >>> tomorrow. >> >> Is the new AllDocs page working now? I think we need to retest it >> before we release it. I'm volunteering for that since last time I >> tried there were a lot of problems. > > Yes the AllDocs and Treeview pages are working.
ok testing now... >> BTW JV, have you been able to apply Sergiu and my comments on >> Evelina's patch for AllDocs, like renaming usersandgroups.css since >> it's no longer about users and groups. I don't remember if there were >> other comments. > > AFAIR I've applied all the recommendations except this one, I thought > this could be part of the future js/css refactoring we'll have to do > after the skinx commit. If it's a small change I'd rather we do it now. It's not good to introduce cruft in the hope that we'll fix it later... This is what got us to have a 6000+ XWiki.java class ;) >> I also think we maybe need to do some smoke tests about the new >> xmlrpc >> implementation and verify XEclipse continues working. WDYT? (has this >> already been done, after it's been committed? It's important to test >> after changes are made since they can break the original patch). >> I also think I've discovered a problem in the patch for redirects. >> The >> following isn't correct I think: >> >> Since sendGlobalRedirect does a response.sendRedirect and we're doing >> another one in the catch... >> > > sendGlobalRedirect doing a response.sendRedirect is very rare, in most > of the cases (99.99%) it does nothing. So are you're saying: screw the people who try to use the redirect feature for redirecting for non existing subwikis? :) I say let's fix it. I can do it, just wanted to make sure I understood correctly since I believe you applied that patch from Raff. Just let me know and I'll fix it. On a different topic, I don't think we should release 1.4M2 right now till we understand a bit better why it fails so miserably on myxwiki.org. It doesn't stay up for more than a day for some reason. At least we need to understand why and then we can take a call: release now and fix in RC1 or postpone the release a bit. WDYT? Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
