Hi Artem,
It seems like you're transforming current storage code into
components. I'm not sure what important advantages this brings. What
I'd like to see is to have new code and new apis use components but
I'm not sure about old code. Maybe you could explain what's your plan?
Do you plan to create clean interfaces for storage? If so this really
needs to be discussed and proposed on the devs list with a design page
on xwiki.org.
However this probably requires a prerequisite of having the new model
in place before it can be started? wdyt?
Thanks
-Vincent
On Jun 17, 2008, at 11:59 PM, amelentev (SVN) wrote:
> Author: amelentev
> Date: 2008-06-17 23:59:26 +0200 (Tue, 17 Jun 2008)
> New Revision: 10384
>
> Modified:
> xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/AttachmentRecycleBinStore.java
> xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/AttachmentVersioningStore.java
> xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiAttachmentStoreInterface.java
> xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiRecycleBinStoreInterface.java
> xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiStoreInterface.java
> xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiVersioningStoreInterface.java
> Log:
> XWIKI-2443: Componentize Store Interfaces
>
> add ROLEs to stores
>
>
> Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/
> xwiki/store/AttachmentRecycleBinStore.java
> ===================================================================
> --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/AttachmentRecycleBinStore.java 2008-06-17 21:43:03 UTC (rev
> 10383)
> +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/AttachmentRecycleBinStore.java 2008-06-17 21:59:26 UTC (rev
> 10384)
> @@ -42,6 +42,11 @@
> public interface AttachmentRecycleBinStore
> {
> /**
> + * This component's role, used when code needs to look it up.
> + */
> + String ROLE = AttachmentRecycleBinStore.class.getName();
> +
> + /**
> * Save attachment to recycle bin, with full history.
> *
> * @param attachment The attachment to save.
>
> Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/
> xwiki/store/AttachmentVersioningStore.java
> ===================================================================
> --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/AttachmentVersioningStore.java 2008-06-17 21:43:03 UTC (rev
> 10383)
> +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/AttachmentVersioningStore.java 2008-06-17 21:59:26 UTC (rev
> 10384)
> @@ -33,6 +33,11 @@
> public interface AttachmentVersioningStore
> {
> /**
> + * This component's role, used when code needs to look it up.
> + */
> + String ROLE = AttachmentVersioningStore.class.getName();
> +
> + /**
> * Load attachment archive from store.
> * @return attachment archive. not null. return empty archive if
> it is not exist in store.
> * @param attachment The attachment of archive.
>
> Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/
> xwiki/store/XWikiAttachmentStoreInterface.java
> ===================================================================
> --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiAttachmentStoreInterface.java 2008-06-17 21:43:03 UTC
> (rev 10383)
> +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiAttachmentStoreInterface.java 2008-06-17 21:59:26 UTC
> (rev 10384)
> @@ -32,6 +32,11 @@
> * @version $Id$
> */
> public interface XWikiAttachmentStoreInterface {
> + /**
> + * This component's role, used when code needs to look it up.
> + */
> + String ROLE = XWikiAttachmentStoreInterface.class.getName();
> +
> void saveAttachmentContent(XWikiAttachment attachment,
> XWikiContext context, boolean bTransaction) throws XWikiException;
> void saveAttachmentContent(XWikiAttachment attachment, boolean
> bParentUpdate, XWikiContext context, boolean bTransaction) throws
> XWikiException;
> void saveAttachmentsContent(List<XWikiAttachment> attachments,
> XWikiDocument doc, boolean bParentUpdate, XWikiContext context,
> boolean bTransaction) throws XWikiException;
>
> Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/
> xwiki/store/XWikiRecycleBinStoreInterface.java
> ===================================================================
> --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiRecycleBinStoreInterface.java 2008-06-17 21:43:03 UTC
> (rev 10383)
> +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiRecycleBinStoreInterface.java 2008-06-17 21:59:26 UTC
> (rev 10384)
> @@ -33,6 +33,11 @@
> public interface XWikiRecycleBinStoreInterface
> {
> /**
> + * This component's role, used when code needs to look it up.
> + */
> + String ROLE = XWikiRecycleBinStoreInterface.class.getName();
> +
> + /**
> * Save document to recycle bin.
> * @param doc - document to save
> * @param deleter - the user which delete document
>
> Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/
> xwiki/store/XWikiStoreInterface.java
> ===================================================================
> --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiStoreInterface.java 2008-06-17 21:43:03 UTC (rev 10383)
> +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiStoreInterface.java 2008-06-17 21:59:26 UTC (rev 10384)
> @@ -31,6 +31,11 @@
>
> public interface XWikiStoreInterface
> {
> + /**
> + * This component's role, used when code needs to look it up.
> + */
> + String ROLE = XWikiStoreInterface.class.getName();
> +
> public void saveXWikiDoc(XWikiDocument doc, XWikiContext
> context) throws XWikiException;
>
> public void saveXWikiDoc(XWikiDocument doc, XWikiContext
> context, boolean bTransaction)
>
> Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/
> xwiki/store/XWikiVersioningStoreInterface.java
> ===================================================================
> --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiVersioningStoreInterface.java 2008-06-17 21:43:03 UTC
> (rev 10383)
> +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
> store/XWikiVersioningStoreInterface.java 2008-06-17 21:59:26 UTC
> (rev 10384)
> @@ -15,6 +15,11 @@
> * @version $Id$
> */
> public interface XWikiVersioningStoreInterface {
> + /**
> + * This component's role, used when code needs to look it up.
> + */
> + String ROLE = XWikiVersioningStoreInterface.class.getName();
> +
> public void loadXWikiDocArchive(XWikiDocumentArchive archivedoc,
> boolean bTransaction, XWikiContext context) throws XWikiException;
> public void saveXWikiDocArchive(XWikiDocumentArchive archivedoc,
> boolean bTransaction, XWikiContext context) throws XWikiException;
> public void updateXWikiDocArchive(XWikiDocument doc, boolean
> bTransaction, XWikiContext context) throws XWikiException;
>
> _______________________________________________
> notifications mailing list
> [EMAIL PROTECTED]
> http://lists.xwiki.org/mailman/listinfo/notifications
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
