On Thu, Jul 10, 2008 at 10:42 AM, Artem Melentyev <[EMAIL PROTECTED]> wrote: > Ludovic Dubost wrote: >> >> Hi developers, >> >> I have been having the need for the exact same function that is >> available as protected in com.xpn.xwiki.api.Document >> I propose we make this api public >> >> http://jira.xwiki.org/jira/browse/XWIKI-2549 >> >> WDYT ? > > +1 > > I think getDoc().save() is not needed in public addAttachment. Because > if user adds 2 attachments then unneeded save will perform. > Explicitly save() is better.
+1 and +1 for not adding save in addAttachment > > -- > Artem Melentyev > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
