Hi,
No plan to transform to interface. I'm not understand the ROLE correctly. Sorry.
Thanks,
Wang Ning
On Mon, Jul 28, 2008 at 11:21 PM, Vincent Massol <[EMAIL PROTECTED]> wrote:
>
> On Jul 28, 2008, at 5:12 PM, daning (SVN) wrote:
>
>> Author: daning
>> Date: 2008-07-28 17:12:52 +0200 (Mon, 28 Jul 2008)
>> New Revision: 394
>>
>> Modified:
>> xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/DefaultOfficeConverter.java
>> xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/OfficeServerConnection.java
>> xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/Util.java
>> xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/filter/Filter.java
>> Log:
>> XSANDBOX-32:
>>
>> Modified: xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/
>> plugin/officeconverter/DefaultOfficeConverter.java
>> ===================================================================
>> --- xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/DefaultOfficeConverter.java 2008-07-28 12:23:27 UTC
>> (rev 393)
>> +++ xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/DefaultOfficeConverter.java 2008-07-28 15:12:52 UTC
>> (rev 394)
>> @@ -135,6 +135,7 @@
>> document = new JDomSerializer(props, true).createJDom(node);
>>
>> Element root = document.getRootElement();
>> +
>> // TODO more filter to be added
>>
>> XHTMLPinLiFilter pinLiFilter = new XHTMLPinLiFilter();
>>
>> Modified: xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/
>> plugin/officeconverter/OfficeServerConnection.java
>> ===================================================================
>> --- xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/OfficeServerConnection.java 2008-07-28 12:23:27 UTC
>> (rev 393)
>> +++ xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/OfficeServerConnection.java 2008-07-28 15:12:52 UTC
>> (rev 394)
>> @@ -7,6 +7,11 @@
>>
>> public class OfficeServerConnection
>> {
>> + /**
>> + * This component's role, used when code needs to look it up.
>> + */
>> + String ROLE = OfficeServerConnection.class.getName();
>> +
>
> The ROLE should be in the interface or maybe you're planning to
> transform this into an interface?
>
> Thanks
> -Vincent
>
>> private static final OfficeServerConnection instance = new
>> OfficeServerConnection();
>>
>> public static final String DEFAULT_HOST = "localhost";
>>
>> Modified: xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/
>> plugin/officeconverter/Util.java
>> ===================================================================
>> --- xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/Util.java 2008-07-28 12:23:27 UTC (rev 393)
>> +++ xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/Util.java 2008-07-28 15:12:52 UTC (rev 394)
>> @@ -97,5 +97,8 @@
>> }
>> }
>> }
>> -
>> +
>> + public static boolean canViewAsHtml(OfficeDocumentType
>> documentType) {
>> + return false;
>> + }
>> }
>>
>> Modified: xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/
>> plugin/officeconverter/filter/Filter.java
>> ===================================================================
>> --- xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/filter/Filter.java 2008-07-28 12:23:27 UTC (rev 393)
>> +++ xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/
>> officeconverter/filter/Filter.java 2008-07-28 15:12:52 UTC (rev 394)
>> @@ -4,6 +4,10 @@
>>
>> public interface Filter
>> {
>> + /**
>> + * This component's role, used when code needs to look it up.
>> + */
>> + String ROLE = Filter.class.getName();
>> void doFilter(Element element);
>> String getName();
>> void setName(String filterName);
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
>
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
