Vincent Massol wrote:
> Hi Artem,
>
> On Sep 7, 2008, at 9:46 PM, amelentev (SVN) wrote:
>
>> Author: amelentev
>> Date: 2008-09-07 21:46:19 +0200 (Sun, 07 Sep 2008)
>> New Revision: 12470
>>
>> Modified:
>> platform/web/trunk/standard/pom.xml
>> Log:
>> XWIKI-1839: Query Plugin needs a jar file
>
> why is this not in the query plugin pom instead?
There is no QueryPlugin pom. old QueryPlugin is inside xwiki-core.
If we view at xwiki-core & jcrstore as a library, we should not add
slf4j logging implementation to it according slf4j.org recommendations.
The idea of slf4j is we can switch logging implementation at deployment
time by just switch logging implementation jar.
So we should add it at more upper level. I think it is xwiki-web/standard.
> For deployment time and not build time only you can use
> <scope>runtime</scope>.
ok. will fix.
>
> Thanks
> -Vincent
>
>> Modified: platform/web/trunk/standard/pom.xml
>> ===================================================================
>> --- platform/web/trunk/standard/pom.xml 2008-09-07 17:16:07 UTC (rev
>> 12469)
>> +++ platform/web/trunk/standard/pom.xml 2008-09-07 19:46:19 UTC (rev
>> 12470)
>> @@ -55,6 +55,13 @@
>> <artifactId>xwiki-core-plexus</artifactId>
>> <version>${platform.core.version}</version>
>> </dependency>
>> + <!-- needed for slf4j clients such as QueryPlugin and JCRStore
>> + It is deployment time logging configuration, so it is here
>> instead of xwiki-core. -->
>> + <dependency>
>> + <groupId>org.slf4j</groupId>
>> + <artifactId>slf4j-log4j12</artifactId>
>> + <version>1.3.0</version>
>> + </dependency>
>> </dependencies>
>> <build>
>> <plugins>
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
--
Artem Melentyev
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
