Vincent Massol wrote:
> On Oct 13, 2008, at 6:10 AM, sdumitriu (SVN) wrote:
> 
>> Author: sdumitriu
>> Date: 2008-10-13 06:10:11 +0200 (Mon, 13 Oct 2008)
>> New Revision: 13522
>>
>> Modified:
>>  platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ 
>> localization/AbstractWikiBundle.java
>>  platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ 
>> localization/Bundle.java
>>  platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ 
>> localization/internal/DefaultWikiInformation.java
>>  platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ 
>> localization/internal/StaticDocumentsBundle.java
>>  platform/core/trunk/xwiki-localization/src/main/resources/META-INF/ 
>> plexus/components.xml
>> Log:
>> XWIKI-2756: New Localization component
>> Fix some errors detected at runtime.
> 
> [snip]
>>                properties.putAll(getDocumentBundle(fullDocumentName,  
>> language));
>>            } catch (Exception ex) {
>> -                getLogger().warn("Exception loading a document  
>> bundle");
>> +                getLogger().warn("Exception loading a document  
>> bundle: " + fullDocumentName);
> 
> Would be good to use "[" + fullDocumentName + "]" (or MessageFormat or  
> the new logger).
> 

Yes, right after I commit the logger patch and write a logging "best
practice".

-- 
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to