My error. Fixing it now. On Fri, Oct 17, 2008 at 1:18 PM, Vincent Massol <[EMAIL PROTECTED]> wrote:
> hmm the code doesn't look commented. > > Asiri can you please fix this for all the new code you've asked to > commit in trunks? At the minimum in places where it's required and at > the maximum it should pass our checkstyle rules. > > Note: You should also add @version and @since tags. > > Thanks > -Vincent > > On Oct 16, 2008, at 5:28 PM, sdumitriu (SVN) wrote: > > > Author: sdumitriu > > Date: 2008-10-16 17:28:20 +0200 (Thu, 16 Oct 2008) > > New Revision: 13636 > > > > Removed: > > platform/xwiki-plugins/trunk/webdav/src/main/resources/ > > platform/xwiki-plugins/trunk/webdav/src/test/resources/ > > Modified: > > platform/xwiki-plugins/trunk/webdav/pom.xml > > platform/xwiki-plugins/trunk/webdav/src/main/java/com/xpn/xwiki/ > > plugin/webdav/XWikiDavApi.java > > platform/xwiki-plugins/trunk/webdav/src/main/java/com/xpn/xwiki/ > > plugin/webdav/XWikiDavPlugin.java > > Log: > > [cleanup] Apply codestyle, add license headers, fix dependencies > > > > > > Modified: platform/xwiki-plugins/trunk/webdav/pom.xml > > =================================================================== > > --- platform/xwiki-plugins/trunk/webdav/pom.xml 2008-10-16 15:18:16 > > UTC (rev 13635) > > +++ platform/xwiki-plugins/trunk/webdav/pom.xml 2008-10-16 15:28:20 > > UTC (rev 13636) > > @@ -1,20 +1,48 @@ > > +<?xml version="1.0" encoding="UTF-8"?> > > + > > +<!-- > > + * > > + * See the NOTICE file distributed with this work for additional > > + * information regarding copyright ownership. > > + * > > + * This is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU Lesser General Public License as > > + * published by the Free Software Foundation; either version 2.1 of > > + * the License, or (at your option) any later version. > > + * > > + * This software is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with this software; if not, write to the Free > > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > > + * > > +--> > > + > > <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi=" > http://www.w3.org/2001/XMLSchema-instance > > " > > - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/maven-v4_0_0.xsd > > "> > > - <modelVersion>4.0.0</modelVersion> > > - <groupId>com.xpn.xwiki.platform.plugins</groupId> > > - <artifactId>xwiki-plugin-webdav</artifactId> > > - <name>xwiki-webdav-plugin</name> > > - <version>0.0.1-SNAPSHOT</version> > > - <dependencies> > > - <dependency> > > - <groupId>com.xpn.xwiki.platform</groupId> > > - <artifactId>xwiki-core</artifactId> > > - <version>1.6-SNAPSHOT</version> > > - </dependency> > > - <dependency> > > - <groupId>com.xpn.xwiki.platform</groupId> > > - <artifactId>xwiki-webdav</artifactId> > > - <version>0.0.1-SNAPSHOT</version> > > - </dependency> > > - </dependencies> > > -</project> > > \ No newline at end of file > > + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/maven-v4_0_0.xsd > > "> > > + <modelVersion>4.0.0</modelVersion> > > + <parent> > > + <groupId>com.xpn.xwiki.platform.plugins</groupId> > > + <artifactId>xwiki-plugins</artifactId> > > + <version>11-SNAPSHOT</version> > > + </parent> > > + <artifactId>xwiki-plugin-webdav</artifactId> > > + <name>XWiki Platform - Plugins - WebDAV plugin</name> > > + <version>0.0.1-SNAPSHOT</version> > > + <dependencies> > > + <dependency> > > + <groupId>com.xpn.xwiki.platform</groupId> > > + <artifactId>xwiki-core</artifactId> > > + <version>1.7-SNAPSHOT</version> > > + </dependency> > > + <dependency> > > + <groupId>com.xpn.xwiki.platform</groupId> > > + <artifactId>xwiki-webdav</artifactId> > > + <version>0.0.1-SNAPSHOT</version> > > + </dependency> > > + </dependencies> > > +</project> > > > > Modified: platform/xwiki-plugins/trunk/webdav/src/main/java/com/xpn/ > > xwiki/plugin/webdav/XWikiDavApi.java > > =================================================================== > > --- platform/xwiki-plugins/trunk/webdav/src/main/java/com/xpn/xwiki/ > > plugin/webdav/XWikiDavApi.java 2008-10-16 15:18:16 UTC (rev 13635) > > +++ platform/xwiki-plugins/trunk/webdav/src/main/java/com/xpn/xwiki/ > > plugin/webdav/XWikiDavApi.java 2008-10-16 15:28:20 UTC (rev 13636) > > @@ -1,3 +1,23 @@ > > +/* > > + * See the NOTICE file distributed with this work for additional > > + * information regarding copyright ownership. > > + * > > + * This is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU Lesser General Public License as > > + * published by the Free Software Foundation; either version 2.1 of > > + * the License, or (at your option) any later version. > > + * > > + * This software is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with this software; if not, write to the Free > > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > > + */ > > + > > package com.xpn.xwiki.plugin.webdav; > > > > import com.xpn.xwiki.XWikiContext; > > @@ -6,16 +26,18 @@ > > import com.xpn.xwiki.api.Document; > > import com.xpn.xwiki.plugin.webdav.utils.XWikiDavUtils; > > > > -public class XWikiDavApi extends Api { > > - > > - private XWikiDavPlugin plugin; > > - > > - public XWikiDavApi(XWikiDavPlugin plugin, XWikiContext context) { > > - super(context); > > - this.plugin = plugin; > > - } > > - > > - public String getDavURL(Document doc, Attachment attachment) { > > - return XWikiDavUtils.getDavURL(doc, attachment); > > - } > > +public class XWikiDavApi extends Api > > +{ > > + private XWikiDavPlugin plugin; > > + > > + public XWikiDavApi(XWikiDavPlugin plugin, XWikiContext context) > > + { > > + super(context); > > + this.plugin = plugin; > > + } > > + > > + public String getDavURL(Document doc, Attachment attachment) > > + { > > + return XWikiDavUtils.getDavURL(doc, attachment); > > + } > > } > > > > Modified: platform/xwiki-plugins/trunk/webdav/src/main/java/com/xpn/ > > xwiki/plugin/webdav/XWikiDavPlugin.java > > =================================================================== > > --- platform/xwiki-plugins/trunk/webdav/src/main/java/com/xpn/xwiki/ > > plugin/webdav/XWikiDavPlugin.java 2008-10-16 15:18:16 UTC (rev 13635) > > +++ platform/xwiki-plugins/trunk/webdav/src/main/java/com/xpn/xwiki/ > > plugin/webdav/XWikiDavPlugin.java 2008-10-16 15:28:20 UTC (rev 13636) > > @@ -1,3 +1,23 @@ > > +/* > > + * See the NOTICE file distributed with this work for additional > > + * information regarding copyright ownership. > > + * > > + * This is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU Lesser General Public License as > > + * published by the Free Software Foundation; either version 2.1 of > > + * the License, or (at your option) any later version. > > + * > > + * This software is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with this software; if not, write to the Free > > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > > + */ > > + > > package com.xpn.xwiki.plugin.webdav; > > > > import com.xpn.xwiki.XWikiContext; > > @@ -5,19 +25,21 @@ > > import com.xpn.xwiki.plugin.XWikiDefaultPlugin; > > import com.xpn.xwiki.plugin.XWikiPluginInterface; > > > > -public class XWikiDavPlugin extends XWikiDefaultPlugin { > > +public class XWikiDavPlugin extends XWikiDefaultPlugin > > +{ > > + public XWikiDavPlugin(String name, String className, > > XWikiContext context) > > + { > > + super(name, className, context); > > + init(context); > > + } > > > > - public XWikiDavPlugin(String name, String className, XWikiContext > > context) { > > - super(name, className, context); > > - init(context); > > - } > > + public String getName() > > + { > > + return "webdav"; > > + } > > > > - public String getName() { > > - return "webdav"; > > - } > > - > > - public Api getPluginApi(XWikiPluginInterface plugin, XWikiContext > > context) { > > - return new XWikiDavApi((XWikiDavPlugin) plugin, context); > > - } > > - > > + public Api getPluginApi(XWikiPluginInterface plugin, > > XWikiContext context) > > + { > > + return new XWikiDavApi((XWikiDavPlugin) plugin, context); > > + } > > } > > > > _______________________________________________ > > notifications mailing list > > [EMAIL PROTECTED] > > http://lists.xwiki.org/mailman/listinfo/notifications > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
