Hi Vincent, On Fri, Oct 17, 2008 at 7:59 PM, Vincent Massol <[EMAIL PROTECTED]> wrote:
> Another pb. The directory structure for /platform/core/xwiki-webdav/ is: > > -rw-r--r-- 1 vmassol staff 153 Oct 17 12:23 README > drwxr-xr-x 6 vmassol staff 204 Oct 17 16:21 database > drwxr-xr-x 3 vmassol staff 102 Oct 17 12:23 eclipse-bin > -rw-r--r-- 1 vmassol staff 5341 Oct 17 12:23 pom.xml > drwxr-xr-x 6 vmassol staff 204 Oct 17 12:23 references > drwxr-xr-x 5 vmassol staff 170 Oct 17 12:23 src > drwxr-xr-x 8 vmassol staff 272 Oct 17 16:21 target > -rw-r--r-- 1 vmassol staff 23205 Oct 17 16:21 xwiki.log > > * README shouldn't be there and is not required. > * database shouldn't be there > * eclipse-bin shouldn't be there > * references should be in test resources if that's needed for tests > Ok, working on a new patch. > > Thanks > -Vincent > > On Oct 17, 2008, at 4:26 PM, Vincent Massol wrote: > > > > > On Oct 17, 2008, at 4:22 PM, Vincent Massol wrote: > > > >> Also, the xml files are not indented properly (they should be using 2 > >> spaces for indentations). > >> > >> Something strange too in platform/core/xwiki-webdav > >> > >> <configuration> > >> <includes> > >> <include>**/ > >> *TTest.java</include> > >> </includes> > >> > >> The strange part is "T" before "Test.java". > > > > Ok I understood this part. Although I think we should discuss this > > more at some point and move functional tests in XE/distribution- > > tests so that we test the real distribution. > > > I did this to separate integration tests from unit tests. But yes, it was kind of a hack at that moment. > > > Another pb: > > > > I see: > > > > <dependency> > > <groupId>tomcat</groupId> > > <artifactId>servlet-api</artifactId> > > <version>5.0.18</version> > > </dependency> > > > > This is a strange groupId. Also I don't believe this should be > > included in the distribution so it should at the very least have a > > "provided" scope. > > > Fixed in http://jira.xwiki.org/jira/browse/XWIKI-2763 Changed to : <dependency> <groupId>javax.servlet</groupId> <artifactId>servlet-api</artifactId> </dependency> as adviced by sergiu. > > > Thanks > > -Vincent > > > > > >> > >> > >> Last the build is not working: > >> > >> [INFO] > >> ------------------------------------------------------------------------ > >> [INFO] Building XWiki Platform - Plugins - WebDAV plugin > >> [INFO] task-segment: [clean, install] > >> [INFO] > >> ------------------------------------------------------------------------ > >> [INFO] [clean:clean] > >> [INFO] snapshot com.xpn.xwiki.platform:xwiki-webdav:0.0.1-SNAPSHOT: > >> checking for updates from apache.snapshots > >> [INFO] snapshot com.xpn.xwiki.platform:xwiki-webdav:0.0.1-SNAPSHOT: > >> checking for updates from xwiki-externals > >> [INFO] snapshot com.xpn.xwiki.platform:xwiki-webdav:0.0.1-SNAPSHOT: > >> checking for updates from xwiki-snapshots > >> Downloading: > http://people.apache.org/maven-snapshot-repository/com/xpn/xwiki/platform/xwiki-webdav/0.0.1-SNAPSHOT/xwiki-webdav-0.0.1-SNAPSHOT.pom > >> Downloading: > http://maven.xwiki.org/externals/com/xpn/xwiki/platform/xwiki-webdav/0.0.1-SNAPSHOT/xwiki-webdav-0.0.1-SNAPSHOT.pom > >> Downloading: > http://maven.xwiki.org/snapshots/com/xpn/xwiki/platform/xwiki-webdav/0.0.1-SNAPSHOT/xwiki-webdav-0.0.1-SNAPSHOT.pom > >> Downloading: > http://people.apache.org/maven-snapshot-repository/com/xpn/xwiki/platform/xwiki-webdav/0.0.1-SNAPSHOT/xwiki-webdav-0.0.1-SNAPSHOT.jar > >> Downloading: > http://maven.xwiki.org/externals/com/xpn/xwiki/platform/xwiki-webdav/0.0.1-SNAPSHOT/xwiki-webdav-0.0.1-SNAPSHOT.jar > >> Downloading: > http://maven.xwiki.org/snapshots/com/xpn/xwiki/platform/xwiki-webdav/0.0.1-SNAPSHOT/xwiki-webdav-0.0.1-SNAPSHOT.jar > >> [INFO] > >> ------------------------------------------------------------------------ > >> [ERROR] BUILD ERROR > >> [INFO] > >> ------------------------------------------------------------------------ > >> [INFO] Failed to resolve artifact. > >> > >> Missing: > >> ---------- > >> 1) com.xpn.xwiki.platform:xwiki-webdav:jar:0.0.1-SNAPSHOT > >> > >> Try downloading the file manually from the project website. > >> > >> Then, install it using the command: > >> mvn install:install-file -DgroupId=com.xpn.xwiki.platform - > >> DartifactId=xwiki-webdav -Dversion=0.0.1-SNAPSHOT -Dpackaging=jar - > >> Dfile=/path/to/file > >> > >> Alternatively, if you host your own repository you can deploy the > >> file there: > >> mvn deploy:deploy-file -DgroupId=com.xpn.xwiki.platform - > >> DartifactId=xwiki-webdav -Dversion=0.0.1-SNAPSHOT -Dpackaging=jar - > >> Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] > >> > >> Path to dependency: > >> 1) com.xpn.xwiki.platform.plugins:xwiki-plugin-webdav:jar: > >> 0.0.1-SNAPSHOT > >> 2) com.xpn.xwiki.platform:xwiki-webdav:jar:0.0.1-SNAPSHOT > >> > >> ---------- > >> 1 required artifact is missing. > >> > >> for artifact: > >> com.xpn.xwiki.platform.plugins:xwiki-plugin-webdav:jar:0.0.1- > >> SNAPSHOT > >> > >> from the specified remote repositories: > >> central (http://repo1.maven.org/maven2), > >> xwiki-externals (http://maven.xwiki.org/externals), > >> xwiki-snapshots (http://maven.xwiki.org/snapshots), > >> xwiki-releases (http://maven.xwiki.org/releases), > >> apache.snapshots (http://people.apache.org/maven-snapshot- > >> repository) > >> > Fixed in http://jira.xwiki.org/jira/browse/XWIKI-2763 > > >> Thanks > >> -Vincent > >> > >> On Oct 17, 2008, at 4:13 PM, Vincent Massol wrote: > >> > >>> Another pb is the versioning used. > >>> > >>> We should always use 1.0-SNAPSHOT and not something like 0.0.1- > >>> SNAPSHOT. > >>> > >>> Thanks > >>> -Vincent > >>> > >>> On Oct 17, 2008, at 4:05 PM, Vincent Massol wrote: > >>> > >>>> Here's what I get when building platform: > >>>> > >>>> ... > >>>> [INFO] XWiki Platform - Core - Query - XWQL > >>>> [INFO] XWiki Platform - Core - Core > >>>> [INFO] XWiki Platform - Tools - XML Doc Update Plugin > >>>> [INFO] XWiki Platform - Tools - Packager > >>>> [INFO] XWiki Platform - Tools - XWiki Configuration Resources > >>>> [INFO] XWiki Platform - Tools - Jetty Configuration Resources > >>>> [INFO] XWiki Platform - Tools - Default (root) webapp for the > >>>> standalone package > >>>> [INFO] FoXWiki - Parent > >>>> [INFO] FoXWiki - Core > >>>> [INFO] FoXWiki - Distribution > >>>> [INFO] XWiki Platform - Core - XMLRPC client > >>>> [INFO] XWiki Platform - Plugins - Parent POM > >>>> [INFO] XWiki Platform - Plugins - Skin Extensions > >>>> [INFO] XWiki Platform - Plugins - Adwords > >>>> [INFO] XWiki Platform - Plugins - Alexa > >>>> [INFO] XWiki Platform - Plugins - eXo Platform > >>>> [INFO] XWiki Platform - Plugins - Joda Time > >>>> [INFO] XWiki Platform - Plugins - Scheduler > >>>> [INFO] XWiki Platform - Plugins - Application Manager > >>>> [INFO] XWiki Platform - Plugins - Wiki Manager > >>>> [INFO] XWiki Platform - Plugins - Mail Sender > >>>> [INFO] XWiki Platform - Plugins - Lucene search > >>>> ... > >>>> > >>>> So the foxwiki tool doesn't have the correct artifactId. > >>>> > Fixed in http://jira.xwiki.org/jira/browse/XWIKI-2763 I'm working on a new patch to correct the rest of errors asap. Thanks. - Asiri > > >>>> That said it's still in the wrong location I believe... I think a > >>>> top level project would be ok. > >>>> > >>>> Thanks > >>>> -Vincent > >>> > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
