Hi Sergiu, should be good now.
cheers Jonas http://jira.xwiki.org/jira/browse/XWIKI-2667 Sergiu Dumitriu wrote: > Jonas von Malottki wrote: >> Hi Sergiu, >> >> sorry to bother, but I noticed that the Interface-file changed. Thus the >> patch will not apply cleanly. Are you going to apply this patch? >> >> Since nobody really objected the MessageFormat I guess it is accepted? >> If it helps I can resubmit a patch using MessageFormat!/? >> > > If you can resubmit a patch, that would be perfect, it would save me > some time thus it will be quickly applied. > > Thank you. > >> Sergiu Dumitriu wrote: >>> Hi devs, >>> >>> I'd like to apply http://jira.xwiki.org/jira/browse/XWIKI-2667 , but one >>> thing I'd like to change is the format of the log messages. The current >>> patch uses String.format, but I prefer MessageFormat, as it is more >>> expressive, and it is already used by the localization tool. >>> >>> So: >>> 1. We use String.format, because: >>> - it is "simpler" (some say) >>> - it is familiar to C/C++ programmers >>> - it is a bit more customizable at the finer level >>> - the code is already written >>> >>> 2. We use MessageFormat, because: >>> - it is already used for localization strings >>> - it is more expressive (I really like the "choice" format) >>> - it is apparently less customizable, but it uses good defaults (I'd >>> rather specify that I want a "long" date format than a "DD MMMM HH:mm:ss >>> z" format) >>> - the changes are minimal >>> - I for one prefer this syntax, rather than the old printf one. >>> >>> My +1 for option 2. > > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
