On Nov 17, 2008, at 6:16 PM, Sergiu Dumitriu wrote:
> Jean-Vincent Drean wrote:
>> On Sun, Nov 16, 2008 at 3:56 AM, SVN sdumitriu
>> <[EMAIL PROTECTED]> wrote:
>>> Author: sdumitriu
>>> @@ -376,9 +372,10 @@
>>> * @return the given text rendered in the context of this
>>> document
>>> * @deprecated since 1.6M1 use [EMAIL PROTECTED]
>>> #getRenderedContent(String, String)}
> ^^^^^^^^^^^
>
>>> */
>>> + @Deprecated
>>> public String getRenderedContent(String text) throws
>>> XWikiException
>>> {
>>> - return doc.getRenderedContent(text, getXWikiContext());
>>> + return this.doc.getRenderedContent(text,
>>> getXWikiContext());
>>> }
>>
>> We currently have 6 pages using this method in XE wiki :
>> http://hudson.xwiki.org/job/xwiki-product-enterprise-test-trunk/com.xpn.xwiki.products$xwiki-enterprise-test-xmlrpc/1574/testReport/
>>
>> WWYT about un-deprecate this method and make it return
>> getRenderedContent(text, getSyntaxId()); ? Seems logical to me since
>> this is what we would do from velocity.
>
> I didn't deprecate it, it was there before (rev. 11285). Vincent?
Yes I deprecated it when I introduced the new rendering. If we're
still using the deprecated version we need to modify the calls to use
the new signature.
Now Sergiu I think you caused the problem in the test since the
@Deprecated annotation seems to have triggered some output in the log
which causes the tests to fail :)
"Using the annotation causes the Java compiler to generate warnings
when the deprecated class, method, or field is used.". Source
http://java.sun.com/j2se/1.5.0/docs/guide/javadoc/deprecation/deprecation.html
3 choices:
1) remove the annotation
2) fix the calls to use the new version
3) modify the tests to not fail on this warning
I think 2) is best, wdyt?
Thanks
-Vincent
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
